Skip to content

Upgrade the Negotiation library#1104

Merged
soyuka merged 2 commits into
api-platform:2.0from
dunglas:Negotiation_94
May 15, 2017
Merged

Upgrade the Negotiation library#1104
soyuka merged 2 commits into
api-platform:2.0from
dunglas:Negotiation_94

Conversation

@dunglas

@dunglas dunglas commented May 8, 2017

Copy link
Copy Markdown
Member
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

See willdurand/Negotiation#94

TODO:

  • Wait for a new tag

@insekticid

Copy link
Copy Markdown
Contributor

create new tag ASAP, because after composer update you get willdurand/negotiation v 2.3 and after that will work only first output normalizer with same format (e.g. json)

api_platform:
    formats:
        jsonld:  ['application/ld+json']
        jsonhal: ['application/hal+json']

request:
curl -X GET --header 'Accept: application/hal+json'
response is in 'ld+json' format (the first one in config)

@soyuka

soyuka commented May 9, 2017

Copy link
Copy Markdown
Member

We're aware of that @insekticid this is why the version should have been patched in #1102! See the root cause here. We're waiting for this to be merged to fix the issue :).

@insekticid

insekticid commented May 9, 2017

Copy link
Copy Markdown
Contributor

I understand, but you should add warning to Api Platform website, or create new Api Platform Core tag 2.0.8 with '"willdurand/negotiation": "^2.0.3 <2.3",' until this will be fixed

@meyerbaptiste

Copy link
Copy Markdown
Member

The new tag is here, this PR can be updated!

@soyuka

soyuka commented May 15, 2017

Copy link
Copy Markdown
Member

Hmm we have the same phpstan errors then in #1113

@soyuka
soyuka merged commit a27905d into api-platform:2.0 May 15, 2017
@soyuka

soyuka commented May 15, 2017

Copy link
Copy Markdown
Member

@dunglas could you set up a new tag (also in api-platform/api-platform)? Thanks!

@dunglas
dunglas deleted the Negotiation_94 branch May 15, 2017 09:25
@dunglas

dunglas commented May 15, 2017

Copy link
Copy Markdown
Member Author

@soyuka why?

@soyuka

soyuka commented May 15, 2017

Copy link
Copy Markdown
Member

Composer should take the last available version of the negotation library? If that's the case, never mind ;).

@dunglas

dunglas commented May 15, 2017

Copy link
Copy Markdown
Member Author

@soyuka yep. And when doing composer install, it will take an older one.

@teohhanhui

Copy link
Copy Markdown
Contributor

@dunglas Bumping the required version of willdurand/negotation is a BC break. 😞

I believe it should be:

"willdurand/negotiation": "^2.0.3 <2.3 || ^2.3.1",

@dunglas

dunglas commented May 15, 2017

Copy link
Copy Markdown
Member Author

I haven't seen this PR was merged. There is no need to do that as a new version of a new version of
willdurand/negotiation has been released. I've opened this PR just to run the test suite with the patched version.
I need to revert this PR.

@soyuka

soyuka commented May 15, 2017

Copy link
Copy Markdown
Member

Yeah sorry my bad, thought it was needed. I've reverted it in #1115

hoangnd25 pushed a commit to hoangnd25/core that referenced this pull request Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants